Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] 🌱 Grouped CI related cherry-picks #2226

Merged
merged 1 commit into from
Aug 15, 2023
Merged

[release-1.7] 🌱 Grouped CI related cherry-picks #2226

merged 1 commit into from
Aug 15, 2023

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Aug 15, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 15, 2023
@sbueringer
Copy link
Member

Changes look good. We probably have to find a way to ignore some markdown for the linkchecker (the stuff we dropped on newer branches)

@chrischdi
Copy link
Member Author

Changes look good. We probably have to find a way to ignore some markdown for the linkchecker (the stuff we dropped on newer branches)

I did not find a way to exclude them. The directory contrib/haproxy/openapi/docs did not get changed for the last 4 years and were introduced in #705 .

We don't use them either so instead of a big toil challenge I removed the entire directory.

@sbueringer
Copy link
Member

sbueringer commented Aug 15, 2023 •
edited
Loading

Sounds good. Looks like you currently only pushed a revert of the flavorgen change?
(on this PR, 1.6 + 1.5 looks fine +/- further linkchecker findings)

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2023
@chrischdi
Copy link
Member Author

Sounds good. Looks like you currently only pushed a revert of the flavorgen change? (on this PR, 1.6 + 1.5 looks fine +/- further linkchecker findings)

Jep, missed pushing this branch too...

@lubronzhan @chrischdi
Grouped CI related cherry-picks
53365cf 
- Add args to golangci-lint to show lines number kubernetes-sigs#2180
- Align github actions with upstream CAPI kubernetes-sigs#2167
- flavorgen generates all flavors by default kubernetes-sigs#2172
  - only CI parts
- Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174
- Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add doctoc and generate + verify targets kubernetes-sigs#2147
  - only CI parts
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bdedc561df4495f526a04c2875bc77e9f076b73b

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5467bb7 into kubernetes-sigs:release-1.7 Aug 15, 2023
11 of 12 checks passed
@chrischdi chrischdi deleted the pr-sync-ci-from-main-1.7 branch August 15, 2023 16:54
@chrischdi chrischdi mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxRink MaxRink Awaiting requested review from MaxRink

@yastij yastij Awaiting requested review from yastij

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @sbueringer @k8s-ci-robot @lubronzhan