📖 Update release documentation & add release issue template #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @killianmuldoon @chrischdi |
sbueringer
changed the title
sbueringer
force-pushed
the
pr-update-release-documentation
branch
from
597f0e4
to
ad2b268
Compare
sbueringer
commented
Aug 3, 2023
| @@ -32,7 +32,7 @@ var _ = PContext("ClusterAPI Upgrade Tests [clusterctl-Upgrade]", func() { | |||
| BootstrapClusterProxy: bootstrapClusterProxy, | |||
| ArtifactFolder: artifactFolder, | |||
| SkipCleanup: skipCleanup, | |||
| InitWithBinary: e2eConfig.GetVariable("INIT_WITH_BINARY_V1ALPHA4"), | |||
| InitWithBinary: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.8/clusterctl-{OS}-{ARCH}", | |||
There was a problem hiding this comment.
This test is currently not run. Just saw this and thought I'll at least slightly improve it.
I'll follow-up with a refactoring to the test folder structure soon
sbueringer
force-pushed
the
pr-update-release-documentation
branch
from
ad2b268
to
37da91b
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-update-release-documentation
branch
2 times, most recently
from
ba8e0c2
to
e894979
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-update-release-documentation
branch
from
e894979
to
4f2edc0
Compare
|
Sounds good. Let me know if I should take another look :-) |
PTAL: #2147 (comment) |
7 tasks
sbueringer
force-pushed
the
pr-update-release-documentation
branch
5 times, most recently
from
ebfb0fb
to
1beeeb3
Compare
sbueringer
force-pushed
the
pr-update-release-documentation
branch
from
1beeeb3
to
c9fd67c
Compare
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm TODO's to be solved on the follow-up. /hold For unhold when you want to :-) Maybe @killianmuldoon wants to give it a look |
k8s-ci-robot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 2455529e8ab64a9a331a44acfec7c7753fe106b9
|
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'm going to ignore the e2e test given that the only relevant change was to a test that isn't executed at all |
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
This was referenced Aug 15, 2023
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 15, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 16, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
chrischdi
pushed a commit
to chrischdi/cluster-api-provider-vsphere
that referenced
this pull request
Aug 16, 2023
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2120