-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update release documentation & add release issue template #2147
📖 Update release documentation & add release issue template #2147
Conversation
/assign @killianmuldoon @chrischdi |
597f0e4
to
ad2b268
Compare
@@ -32,7 +32,7 @@ var _ = PContext("ClusterAPI Upgrade Tests [clusterctl-Upgrade]", func() { | |||
BootstrapClusterProxy: bootstrapClusterProxy, | |||
ArtifactFolder: artifactFolder, | |||
SkipCleanup: skipCleanup, | |||
InitWithBinary: e2eConfig.GetVariable("INIT_WITH_BINARY_V1ALPHA4"), | |||
InitWithBinary: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v0.4.8/clusterctl-{OS}-{ARCH}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is currently not run. Just saw this and thought I'll at least slightly improve it.
I'll follow-up with a refactoring to the test folder structure soon
ad2b268
to
37da91b
Compare
/hold |
ba8e0c2
to
e894979
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits
e894979
to
4f2edc0
Compare
Sounds good. Let me know if I should take another look :-) |
PTAL: #2147 (comment) |
ebfb0fb
to
1beeeb3
Compare
1beeeb3
to
c9fd67c
Compare
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm TODO's to be solved on the follow-up. /hold For unhold when you want to :-) Maybe @killianmuldoon wants to give it a look |
LGTM label has been added. Git tree hash: 2455529e8ab64a9a331a44acfec7c7753fe106b9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm going to ignore the e2e test given that the only relevant change was to a test that isn't executed at all |
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2120