Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 lint: enable nolintlint and fix findings #2294

Merged
merged 1 commit into from
Sep 1, 2023
Merged

🌱 lint: enable nolintlint and fix findings #2294

merged 1 commit into from
Sep 1, 2023

Conversation

MrDXY
Copy link
Contributor

@MrDXY MrDXY commented Aug 29, 2023

What this PR does / why we need it:

  1. Enable the -nolintlint configuration in .golangci.yaml and correct any issues found with ill-formed or insufficiently explained //nolint directives.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Part of #2058

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MrDXY. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2023
@MrDXY MrDXY force-pushed the pr-golangci-sync-nolintlint branch from d1d2869 to d942668 Compare August 29, 2023 07:09
killianmuldoon
killianmuldoon reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2023
killianmuldoon
killianmuldoon reviewed Aug 29, 2023
View reviewed changes
pkg/services/govmomi/vcenter/clone_test.go Outdated Show resolved Hide resolved
test/helpers/vcsim/simulator.go Outdated Show resolved Hide resolved
test/helpers/envtest.go Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed Aug 29, 2023
View reviewed changes
apis/v1alpha4/conversion.go Outdated Show resolved Hide resolved
apis/v1alpha4/vspherecluster_conversion.go Outdated Show resolved Hide resolved
pkg/services/govmomi/vcenter/clone_test.go Outdated Show resolved Hide resolved
test/helpers/envtest.go Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Aug 30, 2023
Merged
@MrDXY MrDXY force-pushed the pr-golangci-sync-nolintlint branch from d942668 to 73f31d5 Compare August 30, 2023 09:27
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2023
sbueringer
sbueringer reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise lgtm

controllers/vmware/test/controllers_suite_test.go Outdated Show resolved Hide resolved
@MrDXY MrDXY force-pushed the pr-golangci-sync-nolintlint branch from 73f31d5 to 2d7c049 Compare August 30, 2023 11:44
chrischdi
chrischdi reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
chrischdi
chrischdi reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

test/helpers/envtest.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@MrDXY MrDXY force-pushed the pr-golangci-sync-nolintlint branch from 2d7c049 to 2bf4219 Compare August 30, 2023 12:01
@MrDXY MrDXY force-pushed the pr-golangci-sync-nolintlint branch from 2bf4219 to 6c47a65 Compare August 30, 2023 12:44
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5079ac20a9c6f43c2405cb28816af311e90df50

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit c595148 into kubernetes-sigs:main Sep 1, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 1, 2023
@sbueringer sbueringer mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@srm09 srm09 Awaiting requested review from srm09

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MrDXY @k8s-ci-robot @sbueringer @chrischdi @killianmuldoon