-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 lint: enable ginkgolinter and fix findings #2282
🌱 lint: enable ginkgolinter and fix findings #2282
Conversation
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nunnatsa Thanks for the PR!
/lgtm
/hold waiting for other reviews
LGTM label has been added. Git tree hash: ba8726e2f04ed15963a48a3667292fd97fc64765
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question to discuss.
Otherwise lgtm.
/lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
trying: |
CAPI PR just merged. Thanks @sbueringer |
/hold cancel |
What this PR does / why we need it
The PR enables ginkgolinter. This linter enforce several standards of using ginkgo and gomega, and can find some bugs in tests (e.g. test with no assertion). The PR also fixes all ginkgolinter findings.
Part of #2058