-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Bump Cluster API to v1.6.0-beta.1 #2463
✨ Bump Cluster API to v1.6.0-beta.1 #2463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test
@killianmuldoon: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-provider-vsphere-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running into a lot of issues - first hurdle being the supervisor unit tests. I can't seem to find a reasonable way to run them individually locally to help debug.
56edb4a
to
d762397
Compare
8cae5cb
to
7aa36fa
Compare
7aa36fa
to
3055202
Compare
3055202
to
03ae98f
Compare
cc7e186
to
c740595
Compare
/test pull-cluster-api-provider-vsphere-e2e-main |
// Update the VSphereCluster and its status in the fake client. | ||
Expect(controllerCtx.ControllerContext.Client.Update(ctx, controllerCtx.VSphereCluster)).To(Succeed()) | ||
Expect(controllerCtx.ControllerContext.Client.Status().Update(ctx, controllerCtx.VSphereCluster)).To(Succeed()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions weren't being used in the underlying test as the object was being checked in place. Some change in the fakeclient seems to have changed how Update
works so that e.g. Status
update also mutates the object in place making this function not work. Fine to get rid of it here, and there weren't that many changes needed for this bump.
I do wonder with how often Update
functions are used across the code what kind of bugs are being missed though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good so far. I hope we never use update outside of tests and use patch instead.
I think the changes in fake client were only to get them closer to the behavior of the real client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: "being checked in place" this means our reconciler code is just reading it from our magic ctx and not via the client. So there is no need for the VSphereCluster object to exist in the fakeclient, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly
// Update the VSphereCluster and its status in the fake client. | ||
Expect(controllerCtx.ControllerContext.Client.Update(ctx, controllerCtx.VSphereCluster)).To(Succeed()) | ||
Expect(controllerCtx.ControllerContext.Client.Status().Update(ctx, controllerCtx.VSphereCluster)).To(Succeed()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above - the object is being checked in place in this test so no need to update it in the fake client.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2463 +/- ##
==========================================
- Coverage 63.67% 63.38% -0.30%
==========================================
Files 123 123
Lines 8773 8788 +15
==========================================
- Hits 5586 5570 -16
- Misses 2773 2797 +24
- Partials 414 421 +7
☔ View full report in Codecov by Sentry. |
c740595
to
acd7f90
Compare
/test pull-cluster-api-provider-vsphere-e2e-main |
/test pull-cluster-api-provider-vsphere-e2e-full-main |
Thx! A few smaller findings. I compared a bit with core CAPI |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
acd7f90
to
83ba5d1
Compare
@killianmuldoon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thx! |
/lgtm |
LGTM label has been added. Git tree hash: 3e4f12c4143f67edad495fa60d98515453ceea37
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump Cluster API to v1.6.0-beta.0.
The release notes are here: https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.6.0-beta.0