-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure finalizers are re-reconciled in CAPV #2357
Comments
/assign |
Depends on kubernetes-sigs/cluster-api#9471 and thereafter updating CAPI dependencies in CAPV, to the next upcoming release. |
We should backport those test utils so we can get this in CAPI v1.5.3. |
@adityabhatia - this should be unblocked in #2463 |
@adityabhatia Just in case you had time to work on it, any updates? :) |
Thanks, this got lost between the years :) This is already worked upon, but it would require some changes to the CAPI framework upstream, captured in this feature request and implemented here |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@sbueringer / @adityabhatia : can we close this since the following PR was merged: |
This issue should have been closed with the PR, but it was tagged incorrectly. 😄 /close |
@adityabhatia: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a tracking issue for similar work in upstream Cluster API
CAPV should add tests to ensure that finalizers added to objects can be correctly re-added if they are incorrectly removed. The desired state of an object without a deletionTimestamp is that it has the correct finalizers in place.
This can be tested in a similar way to the OwnerReference end-to-end tests. The test should remove all finalizers and then force objects to re-reconcile. The objects should have the same finalizers in place after reconciliation as before.
An early prototype of this test in upstream CAPI is #7614 (files), but the underlying code has moved since the PoC.
Note: it might be better to make this change in CAPI first so we can import utils from upstream.
The text was updated successfully, but these errors were encountered: