Ensure finalizers are re-reconciled in CAPV

[killianmuldoon]

This is a tracking issue for similar work in upstream Cluster API

CAPV should add tests to ensure that finalizers added to objects can be correctly re-added if they are incorrectly removed. The desired state of an object without a deletionTimestamp is that it has the correct finalizers in place.

This can be tested in a similar way to the OwnerReference end-to-end tests. The test should remove all finalizers and then force objects to re-reconcile. The objects should have the same finalizers in place after reconciliation as before.

An early prototype of this test in upstream CAPI is #7614 (files), but the underlying code has moved since the PoC.

Note: it might be better to make this change in CAPI first so we can import utils from upstream.

[adityabhatia]

/assign

[adityabhatia]

Depends on kubernetes-sigs/cluster-api#9471 and thereafter updating CAPI dependencies in CAPV, to the next upcoming release.

[killianmuldoon]

We should backport those test utils so we can get this in CAPI v1.5.3.

[killianmuldoon]

@adityabhatia - this should be unblocked in #2463

[sbueringer]

@adityabhatia Just in case you had time to work on it, any updates? :)

[adityabhatia]

@adityabhatia Just in case you had time to work on it, any updates? :)

Thanks, this got lost between the years :) This is already worked upon, but it would require some changes to the CAPI framework upstream, captured in this feature request and implemented here

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[chrischdi]

@sbueringer / @adityabhatia : can we close this since the following PR was merged:

• 🌱 test: Ensure finalizers are re-reconciled #2626

[adityabhatia]

This issue should have been closed with the PR, but it was tagged incorrectly. 😄

/close

[k8s-ci-robot]

@adityabhatia: Closing this issue.

In response to this:

This issue should have been closed with the PR, but it was tagged incorrectly. 😄

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.