Ensure finalizers are re-reconciled in Cluster API

[killianmuldoon]

Cluster API should add tests to ensure that finalizers added to objects can be correctly re-added if they are incorrectly removed. The desired state of an object without a deletionTimestamp is that it has the correct finalizers in place.

This can be tested in a similar way to the OwnerReference end-to-end tests. The test should remove all finalizers and then force objects to re-reconcile. The objects should have the same finalizers in place after reconciliation as before.

An early prototype of this test is in https://github.com/kubernetes-sigs/cluster-api/pull/7614/files, but the underlying code has moved since the PoC.

[killianmuldoon]

/help

[k8s-ci-robot]

@killianmuldoon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/triage accepted

[adityabhatia]

/assign