-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure finalizers are re-reconciled in Cluster API #9434
Comments
/help |
@killianmuldoon: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
/assign |
Cluster API should add tests to ensure that finalizers added to objects can be correctly re-added if they are incorrectly removed. The desired state of an object without a
deletionTimestamp
is that it has the correct finalizers in place.This can be tested in a similar way to the OwnerReference end-to-end tests. The test should remove all finalizers and then force objects to re-reconcile. The objects should have the same finalizers in place after reconciliation as before.
An early prototype of this test is in https://github.com/kubernetes-sigs/cluster-api/pull/7614/files, but the underlying code has moved since the PoC.
The text was updated successfully, but these errors were encountered: