Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add Kubernetes cluster upgrade test #2593

Merged
merged 1 commit into from
Jan 9, 2024
Merged

🌱 Add Kubernetes cluster upgrade test #2593

merged 1 commit into from
Jan 9, 2024

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jan 5, 2024 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR adds a Kubernetes upgrade test (v1.28 => v1.29)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2024
@sbueringer sbueringer changed the title 🌱 Add Kubernetes cluster upgrade test [WIP] 🌱 Add Kubernetes cluster upgrade test Jan 5, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0f7a74) 64.68% compared to head (8ee435a) 64.77%.
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2593      +/-   ##
==========================================
+ Coverage   64.68%   64.77%   +0.08%     
==========================================
  Files         118      118              
  Lines        8578     8578              
==========================================
+ Hits         5549     5556       +7     
+ Misses       2598     2592       -6     
+ Partials      431      430       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sbueringer
sbueringer commented Jan 5, 2024
View reviewed changes
test/go.mod Outdated Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-add-upgrade-test branch 2 times, most recently from 89f7fb6 to 470469b Compare January 8, 2024 13:38
sbueringer
sbueringer commented Jan 8, 2024
View reviewed changes
test/go.mod Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @chrischdi

This PR is ready for review. Just waiting for #2593 (comment)

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@sbueringer sbueringer changed the title [WIP] 🌱 Add Kubernetes cluster upgrade test 🌱 Add Kubernetes cluster upgrade test Jan 8, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

chrischdi
chrischdi reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for merge of kubernetes-sigs/cluster-api#9963 and updating the replace.

@sbueringer
Add Kubernetes cluster upgrade test
8ee435a 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-full-main

@sbueringer
Copy link
Member Author

@chrischdi Should be fine now. +/- green CI

chrischdi
chrischdi reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@sbueringer
Copy link
Member Author

sbueringer commented Jan 9, 2024 •
edited
Loading

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 9, 2024
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ae707243034926ee50bd9483f43d3ca7f97101c

@k8s-ci-robot k8s-ci-robot merged commit d7344c6 into kubernetes-sigs:main Jan 9, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 9, 2024
@sbueringer sbueringer deleted the pr-add-upgrade-test branch January 9, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@yastij yastij Awaiting requested review from yastij

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @chrischdi @fabriziopandini