🌱 Make etcd and CoreDNS optional in upgrade and self-hosted tests #9963
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sbueringer
added
area/e2e-testing
k8s-ci-robot
added
the
size/M
|
/cherry-pick release-1.6 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @fabriziopandini @chrischdi |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c3db1ffb37a8175952b0ef0c6d53fa51d024d71d
|
|
/hold I'll test a cherry-picked version of it here: https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/2593/files |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel test is green in CAPV (without setting the etcd & coredns tags) |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #9965 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
We should not force infra providers to set etcd and coreDNS version to be able to test Kubernetes upgrades (and thus have corresponding etcd & coreDNS variables if they use ClusterClass)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #