-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add vm-operator tilt settings #2803
🌱 Add vm-operator tilt settings #2803
Conversation
spec: | ||
containers: | ||
- name: manager | ||
imagePullPolicy: Always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aligns vm operator to all the other providers; TBD if we prefer if not present or if we want to switch to if not present in our E2E test config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
+ Coverage 64.06% 64.26% +0.20%
==========================================
Files 160 160
Lines 9367 9367
==========================================
+ Hits 6001 6020 +19
+ Misses 2909 2895 -14
+ Partials 457 452 -5 ☔ View full report in Codecov by Sentry. |
/hold |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: c0c123bbc0865e27cba4de04abd0ec9c41a24b13
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quick note. If we realize that we have to debug the vm-operator regularly, I would explore if we can just build+push the vm-operator image with debug symbols. If I'm not missing anything we can then use dlv the same way. Also IIRC there were some improvements over time in Go and dlv that some minimal debugging is even possible without including debug symbols into the binary. But let's consider this if it ever becomes relevant |
What this PR does / why we need it:
This PR add tilt settings for vm-operator using the same image/manifest we are using for CI.
NOTE: with this configuration we cannot debug vm-operator, but this is considered acceptable because we don't need this in most of the cases.
If necessary to debug vm-operator it is requried to temporarily add a tilt settings in the vm-operator repo and do the same small modifications we are doing in the test/infrastructure/vm-operator folder