Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add vm-operator tilt settings #2803

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR add tilt settings for vm-operator using the same image/manifest we are using for CI.
NOTE: with this configuration we cannot debug vm-operator, but this is considered acceptable because we don't need this in most of the cases.
If necessary to debug vm-operator it is requried to temporarily add a tilt settings in the vm-operator repo and do the same small modifications we are doing in the test/infrastructure/vm-operator folder

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2024
spec:
containers:
- name: manager
imagePullPolicy: Always
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns vm operator to all the other providers; TBD if we prefer if not present or if we want to switch to if not present in our E2E test config

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (26932c8) to head (ba9f536).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
+ Coverage   64.06%   64.26%   +0.20%     
==========================================
  Files         160      160              
  Lines        9367     9367              
==========================================
+ Hits         6001     6020      +19     
+ Misses       2909     2895      -14     
+ Partials      457      452       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziopandini
Copy link
Member Author

/hold
for kubernetes-sigs/cluster-api#10244

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0c123bbc0865e27cba4de04abd0ec9c41a24b13

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 936c258 into kubernetes-sigs:main Mar 13, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 13, 2024
@sbueringer
Copy link
Member

sbueringer commented Mar 13, 2024

Quick note. If we realize that we have to debug the vm-operator regularly, I would explore if we can just build+push the vm-operator image with debug symbols. If I'm not missing anything we can then use dlv the same way.

Also IIRC there were some improvements over time in Go and dlv that some minimal debugging is even possible without including debug symbols into the binary.

But let's consider this if it ever becomes relevant

@fabriziopandini fabriziopandini deleted the add-vm-operator-tilt-settings branch March 25, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants