Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Allow tilt provider with pre-build images #10244

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
With this PR it is now possible to use tilt providers with probuilt images (images already pushed somewhere, not manage by tilt build_docker_image).

This is useful for test published images, and it came at the cost that for those images it is not possible to activate debud/live reload, which is acceptable for the given use case.

/area devtools

@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2024
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits

hack/tools/internal/tilt-prepare/main.go Outdated Show resolved Hide resolved
hack/tools/internal/tilt-prepare/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@chrischdi
Copy link
Member

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@fabriziopandini fabriziopandini force-pushed the allow-tilt-provider-without-building-images branch from 7077c9c to b0bbf9d Compare March 11, 2024 12:35
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

/hold feel free to unhold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d48a414c7e052c62a328e8908a919420e1642ebe

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit fed27ee into kubernetes-sigs:main Mar 11, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Mar 11, 2024
@sbueringer
Copy link
Member

sbueringer commented Mar 15, 2024

@fabriziopandini Just to confirm. This can be used by not specifying image, live_reload_deps and debug settings (in tilt-settings.yaml) for a provider?

@fabriziopandini
Copy link
Member Author

Yes, if you omit image, then live_reload_deps and debug do not make sense anymore.
But as a clarification, it is also a valid use case to have image and not live_reload_deps and debug (and this was not working before)

@fabriziopandini fabriziopandini deleted the allow-tilt-provider-without-building-images branch March 25, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants