🌱 tilt: ensure in-tree providers always use start.sh to allow restarts #10811
+20
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/devtools
sbueringer
reviewed
Jun 28, 2024
| @@ -137,6 +143,9 @@ type tiltProviderConfig struct { | |||
| ApplyProviderYaml *bool `json:"apply_provider_yaml,omitempty"` | |||
| KustomizeFolder *string `json:"kustomize_folder,omitempty"` | |||
| KustomizeOptions []string `json:"kustomize_options,omitempty"` | |||
|
|
|||
| // hardCodedProvider is used for providers hardc-oded in the Tiltfile to always set cmd for them to start.sh to allow restarts. | |||
There was a problem hiding this comment.
Suggested change
| // hardCodedProvider is used for providers hardc-oded in the Tiltfile to always set cmd for them to start.sh to allow restarts. | |
| // hardCodedProvider is used for providers hardcoded in the Tiltfile to always set cmd for them to start.sh to allow restarts. |
|
/approve |
|
Thx for fixing this! |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 66d003e201bf3cf347fb5b4fb1ebc164bcd3a1c4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold to fix typo |
k8s-ci-robot
added
the
do-not-merge/hold
chrischdi
force-pushed
the
pr-tilt-fix-restart-core-providers
branch
from
9aa60a6
to
a8c8ed0
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold cancel Needs another lgtm, fixed the typo |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 928a88ac1dfb0d89361051a72ad77553cb300017
|
|
/retest |
|
Nice ty! |
|
@cahillsf thx for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The in-tree providers have hardcoded their provider options in
Tiltbuild. Therefor the values we have intilt-preparedo not reflect the real ones.Since implementing #10244, when using a
tilt-settings.yamlfile without debug configuration for the in-tree providers, tilt-prepare won't adjust the cmd to usestart.shand because of that restarts via tilt did not work anymore.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #10810
/area devtools