-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make MachineDeployment.Spec.Strategy a pointer (#551)
This is required in order to allow defaulting it via a MutatingWebhook. When it is a literal and the user creates a MachineDeployment where that property does not exist, the creation of a jsonpatch will happen based on a representation where that field exists, since literals always gets marshaled. This means a generated jsonpatch will get refused by the APIServer which doesn't know anything about that field with an error like this: `doc is missing path: "/spec/strategy/type"`
- Loading branch information
1 parent
8525414
commit cf502e7
Showing
3 changed files
with
7 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters