Make MachineDeployment.Spec.Strategy a pointer #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Ref: #552 |
This is required in order to allow defaulting it via a MutatingWebhook. When it is a literal and the user creates a MachineDeployment where that property does not exist, the creation of a jsonpatch will happen based on a representation where that field exists, since literals always gets marshaled. This means a generated jsonpatch will get refused by the APIServer which doesn't know anything about that field with an error like this: `doc is missing path: "/spec/strategy/type"`
alvaroaleman
force-pushed
the
deployment-spec-strategy-pointer
branch
from
c48740e
to
b5d2c67
Compare
|
@roberthbailey Can this be merged now? |
|
Yes. /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in order to allow defaulting it via a MutatingWebhook.
When it is a literal and the user creates a MachineDeployment where that
property does not exist, the creation of a jsonpatch will happen based
on a representation where that field exists, since literals always gets
marshaled. This means a generated jsonpatch will get refused by the
APIServer which doesn't know anything about that field with an error
like this:
doc is missing path: "/spec/strategy/type"What this PR does / why we need it:
This is required to allow defaulting
MachineDeployment.Spec.Strategyvia aMutatingWebhookWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
/assign @roberthbailey