Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed MachineDeployment MinReadySeconds to int32 #613

Closed
wants to merge 1 commit into from

Conversation

chrigl
Copy link

@chrigl chrigl commented Dec 3, 2018

What this PR does / why we need it:

MachineDeployment crashes when no MinReadySeconds are provided. See #612

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #612

Special notes for your reviewer:

Release note:


@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrigl
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: justinsb

If they are not already assigned, you can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Contributor

Will this break webhook defaulting (see #551)?

/cc @alvaroaleman

Also, I think this may be fixed by #599 (from @justinsb).

@chrigl
Copy link
Author

chrigl commented Dec 3, 2018

Thanks @roberthbailey, you are right. I will close this one and follow up in #599

@chrigl chrigl closed this Dec 3, 2018
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
Updated docs to use K8s v1.15.4 image and added to table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

machineDeployment controller panics when there is no MinReadySeconds provided
3 participants