-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/docker/docker from 24.0.7+incompatible to 25.0.1+incompatible in /test #10072
Comments
This issue is currently awaiting triage. If CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Wasn't this done in: #10057 ? |
(ah this is not on release-1.6) |
If we can backport it to v1.6 that will unlock our docker module uplfit from the next capi patch else we wait for v1.7 |
The general policy is to not backport dependency bumps unless there's a good reason - is there something which makes the docker bump a requirement on your side? v1.7 is due for release in mid-April. |
No requirement for now we can hold our uplift until 1.7 release. |
Thanks for clarifying. Let's close this. /close |
@killianmuldoon: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added (User Story)?
As a developer using capi test module I would like to bump
github.com/docker/docker
and fix incompatibility issue when using this module in capi test.Detailed Description
when trying to bump github.com/docker/docker to 25.0.1 got an error
sigs.k8s.io/cluster-api/test@v1.6.1/infrastructure/container/docker.go:408:54: cannot use restartPolicy (variable of type string) as "github.com/docker/docker/api/types/container".RestartPolicyMode value in struct literal
The type was changed in this PR moby/moby#44704 but capi is still using the type stringcluster-api/test/infrastructure/container/docker.go
Line 408 in a150f71
Anything else you would like to add?
No response
Label(s) to be applied
/kind feature
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
The text was updated successfully, but these errors were encountered: