Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 bump github.com/docker/docker from 24.0.7 -> 25.0.0 #10057

Merged
merged 1 commit into from
Jan 26, 2024
Merged

馃尡 bump github.com/docker/docker from 24.0.7 -> 25.0.0 #10057

merged 1 commit into from
Jan 26, 2024

Conversation

adityabhatia
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10045

/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @adityabhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 25, 2024
adityabhatia
adityabhatia commented Jan 25, 2024
View reviewed changes
test/infrastructure/container/interface.go
// If not set, defaults to "unless-stopped".
RestartPolicy string
// If not set, defaults to RestartPolicyUnlessStopped.
RestartPolicy dockercontainer.RestartPolicyMode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any usage for RestartPolicy in public repositories

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, see:

cluster-api/test/README.md

Line 5 in f13793d

This package is not subject to deprecation notices or compatibility guarantees.

killianmuldoon
killianmuldoon reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2024
@killianmuldoon
Copy link
Contributor

BTW - you should really try to get sigs membership - happy to sponsor!

@sbueringer
Copy link
Member

BTW - you should really try to get sigs membership - happy to sponsor!

+1

@chrischdi
Copy link
Member

/lgtm

I would not say that this is a breaking (鈿狅笍 ) change, more seedling 馃尡 ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: babef158fdcab58a2abcc1ece8d18cb2926f9a8c

@adityabhatia
Copy link
Contributor Author

/lgtm

I would not say that this is a breaking (鈿狅笍 ) change, more seedling 馃尡 ?

Only because this struct is exported, I marked it as a breaking change, WDYT?

@sbueringer
Copy link
Member

sbueringer commented Jan 25, 2024 •
edited
Loading

/lgtm
I would not say that this is a breaking (鈿狅笍 ) change, more seedling 馃尡 ?

Only because this struct is exported, I marked it as a breaking change, WDYT?

We have this node that we can do whatever we want basically in this part of our code base:

cluster-api/test/README.md

Line 5 in f13793d

This package is not subject to deprecation notices or compatibility guarantees.

But this only means we can break stuff, not how to surface it in release notes.

Basically we have the trade-off of "technically it's a breaking change" vs. "it will show up on top of our release notes but 99% of our users don't care and it's easy to adopt to"

I'm fine either way

/lgtm

/assign @fabriziopandini

@adityabhatia adityabhatia changed the title 鈿狅笍 bump github.com/docker/docker from 24.0.7 -> 25.0.0 馃尡 bump github.com/docker/docker from 24.0.7 -> 25.0.0 Jan 25, 2024
@adityabhatia
Copy link
Contributor Author

adityabhatia commented Jan 25, 2024 •
edited
Loading

/lgtm
I would not say that this is a breaking (鈿狅笍 ) change, more seedling 馃尡 ?

Only because this struct is exported, I marked it as a breaking change, WDYT?

We have this node that we can do whatever we want basically in this part of our code base:

cluster-api/test/README.md

Line 5 in f13793d

This package is not subject to deprecation notices or compatibility guarantees.

But this only means we can break stuff, not how to surface it in release notes.

Basically we have the trade-off of "technically it's a breaking change" vs. "it will show up on top of our release notes but 99% of our users don't care and it's easy to adopt to"

I'm fine either way

/lgtm

/assign @fabriziopandini

Thanks, going by this it makes sense I will change it to 馃尡 as @chrischdi also suggested.

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0f55580 into kubernetes-sigs:main Jan 26, 2024
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 26, 2024
@adityabhatia adityabhatia mentioned this pull request Jan 26, 2024
Closed
9 tasks
@chrischdi chrischdi mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

github.com/docker/docker from 24.0.7 to 25.0.0
6 participants
@adityabhatia @k8s-ci-robot @killianmuldoon @sbueringer @chrischdi @fabriziopandini