Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relevant code from controlplane to util package #2063

Closed
dlipovetsky opened this issue Jan 14, 2020 · 11 comments
Closed

Move relevant code from controlplane to util package #2063

dlipovetsky opened this issue Jan 14, 2020 · 11 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@dlipovetsky
Copy link
Contributor

Some functions (e.g. that fetch or filter Machines) should be moved from the controlplane package to the util package.

(Issue came out of this discussion: #2037 (comment))

@ncdc ncdc added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 15, 2020
@ncdc ncdc added this to the Next milestone Jan 15, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2020
@detiber
Copy link
Member

detiber commented Apr 14, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 14, 2020
@vincepri
Copy link
Member

@benmoss this might be worthwhile to explore this cycle

@vincepri vincepri removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 20, 2020
@vincepri
Copy link
Member

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot modified the milestones: Next, v0.3.x Apr 20, 2020
@benmoss
Copy link

benmoss commented Apr 20, 2020

/assign

@vincepri
Copy link
Member

/milestone v0.3.6

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.x, v0.3.6 Apr 30, 2020
@benmoss
Copy link

benmoss commented May 11, 2020

@dlipovetsky is this still relevant? We now rely a lot on the FilterableMachineCollection in KCP, would that be what we want to move to util?

@vincepri
Copy link
Member

/help
/priority backlog
/milestone v0.3.x

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/priority backlog
/milestone v0.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.6, v0.3.x May 15, 2020
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 15, 2020
@dlipovetsky
Copy link
Contributor Author

I think this got done, but the issue wasn't closed.

@CecileRobertMichon
Copy link
Contributor

Actually did this in #4160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

8 participants