-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Implement delete for KubeadmControlPlane #2037
✨ Implement delete for KubeadmControlPlane #2037
Conversation
@dlipovetsky: GitHub didn't allow me to request PR reviews from the following users: cha. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks ok to me, deferring to @chuckha |
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
/hold I want to squash the fixups before merging. |
f60e4be
to
67ed076
Compare
I addressed all requests for changes and marked the threads "resolved." There are a couple threads I left unresolved because they are discussions. |
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the issues are filed and commits squashed is there anything left to do?
/approve
/assign @vincepri
for lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not sure if this is relevant to this PR, but do we have a design/plan for downscale? I am particularly interested in how this will be done safely with etcd quorum etc.. |
Here is the general plan: https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/proposals/20191017-kubeadm-based-control-plane.md#scale-down |
This makes it easier to split apart "get all machines" from "filter on owned machines" functionality. Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
ab40db6
to
5e03d6d
Compare
Squashed! |
/hold cancel |
I'm going to merge this at the end of today if there are no more review comments |
I see no additional comments /lgtm |
What this PR does / why we need it: Implement delete for KubeadmControlPlane. Part of #1756.
Special notes for reviewers:
Machine.Spec.ClusterName
, but the code base still uses the cluster label to filter, which is why I also did this inGetMachinesForCluster
./cc @chuckha @detiber @randomvariable