🐛 Kubeadm-based Control Plane: Fix error handling during cleanup #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If err is nil, the condition evaluates to true. The condition should evaluate to true only if there is an actual error. Signed-off-by: Daniel Lipovetsky <dlipovetsky@d2iq.com>
k8s-ci-robot
added
cncf-cla: yes
chuckha
approved these changes
Jan 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ncdc
added
the
area/control-plane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes a minor bug in the error handling. If err is nil, the condition evaluates to true. The condition should evaluate to true only if there is an actual error.
I discovered this issue when I was working on #2037. Other code that evaluates
!apierrors.IsNotFoundalready checks that the error is not nil.