Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-hosted E2E tests should also make sure that clusterctl does not own any fields at the end of the move operation #7510

Closed
ykakarap opened this issue Nov 7, 2022 · 2 comments · Fixed by #7513
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl area/testing Issues or PRs related to testing triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@ykakarap
Copy link
Contributor

ykakarap commented Nov 7, 2022

Detailed Description

#7504 fixes the issue that clusterctl move takes ownership of all the fields of the clusters causing potential ownership conflicts.
The E2E tests should now also make sure to check that the clusterctl move operation not give clusterctl ownership of any of the fields.

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind test

/assign

@k8s-ci-robot
Copy link
Contributor

@ykakarap: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

Detailed Description

#7504 fixes the issue that clusterctl move takes ownership of all the fields of the clusters causing potential ownership conflicts.
The E2E tests should now also make sure to check that the clusterctl move operation not give clusterctl ownership of any of the fields.

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind test

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 7, 2022
@fabriziopandini
Copy link
Member

/triage accepted
/milestone v1.3

I will put this in the 1.3 milestone given that this can merge also after RC, but we can eventually reconsider if we don't have bandwidth

@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2022
@sbueringer sbueringer added area/clusterctl Issues or PRs related to clusterctl area/testing Issues or PRs related to testing labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl area/testing Issues or PRs related to testing triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants