-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 patch managed fields after clusterctl move
so that it does not own all fields
#7504
🐛 patch managed fields after clusterctl move
so that it does not own all fields
#7504
Conversation
Can we do this by extending our self_hosted e2e test instead? Basically we should check e.g. the Cluster & ClusterClass that clusterctl doesn't own any fields (after "Moving the cluster to self hosted") I would be totally fine with doing this in a follow-up PR to get this bugfix in time for the next v1.3 beta and v1.2.5 |
Only one nit from my side |
+1 to covering this in E2E tests. |
e98a9e6
to
3a717cb
Compare
Opened an issue to track the E2E work: #7510 |
/test pull-cluster-api-e2e-full-main |
/lgtm |
/cherry-pick release-1.2 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #7512 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR patches the managed fields so that clusterctl does not own all the fields in the object.
Note: The last step of
move
is unpausing the cluster. So clusterctl still ownes the.spec.paused
field on the Clusters and thecluster.x-k8s.io/paused
annotation on the ClusterClasses.So if someone tries to unpause the cluster using SSA it will throw a conflict.
TODO:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #7473