Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HelperOptions with ssa.FilterObjectInput #8395

Closed
ykakarap opened this issue Mar 28, 2023 · 9 comments · Fixed by #9512
Closed

Replace HelperOptions with ssa.FilterObjectInput #8395

ykakarap opened this issue Mar 28, 2023 · 9 comments · Fixed by #9512
Assignees
@musaprg
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ykakarap
Copy link
Contributor

Detailed Description:

With the introduction of ssa.FilterObjectInput in #8060 HelperOptions becomes redundant.

This issue is to drop HelperOptions and replace all of it uses with ssa.FilterObjectInput.

/kind cleanup
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 28, 2023
@ykakarap
Copy link
Contributor Author

/help

@k8s-ci-robot
Copy link
Contributor

@ykakarap:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 28, 2023
@ykakarap ykakarap mentioned this issue Mar 28, 2023
Closed
19 tasks
@fabriziopandini
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 28, 2023
@cahillsf
Copy link
Member

cahillsf commented Apr 9, 2023

👋 I can grab this one. Looks like HelperOptions has a utility function (newHelperOptions) that is being used in one place (serversidepathhelper.go). Should this PR also include a similar utility function for FilterObjectInput?

/assign @cahillsf

@cahillsf
Copy link
Member

/unassign @cahillsf

@Dhairya-Arora01
Copy link
Contributor

Hey @ykakarap how should we change this https://github.com/ykakarap/cluster-api/blob/197e7f90b2d8f25ffbd0b428e7c5197f3364c93c/internal/controllers/topology/cluster/structuredmerge/serversidepathhelper.go#L44

@musaprg
Copy link
Member

musaprg commented Sep 26, 2023

@Dhairya-Arora01 Hi, are you still working on this? I'm interested in implementing this, but I'd like to check if you've already started the preparation for the PR to avoid duplication.

@Dhairya-Arora01
Copy link
Contributor

@musaprg you can work on this if you have figured it out

@musaprg
Copy link
Member

musaprg commented Sep 26, 2023

OK, thank you! I'll take this and prepare an initial PR for it. Let us discuss the implementation details there.
/assign @musaprg

@musaprg musaprg mentioned this issue Oct 1, 2023
Merged
@musaprg musaprg mentioned this issue Oct 17, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@musaprg musaprg

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Embed ssa.FilterObjectInput into HelperOption to remove duplication musaprg/cluster-api
6 participants
@fabriziopandini @musaprg @k8s-ci-robot @ykakarap @cahillsf @Dhairya-Arora01