-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ in-place propagation from MS to InfraMachine and BootstrapConfig #8060
⚠️ in-place propagation from MS to InfraMachine and BootstrapConfig #8060
Conversation
/hold until #7921 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me
internal/controllers/machinedeployment/machinedeployment_controller.go
Outdated
Show resolved
Hide resolved
98d9e66
to
5dd7067
Compare
/test pull-cluster-api-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall direction sounds good to me.
I would do one final round of nitpickery once we merged the underlying PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a first look the approach is ok, and with some little refactoring we can make the code simpler to read and to unit test
5dd7067
to
2dc9d5e
Compare
/test pull-cluster-api-e2e-full-main |
/hold cancel |
/retest |
1 similar comment
/retest |
2dc9d5e
to
d70e7d6
Compare
/test pull-cluster-api-e2e-full-main |
Great work!! /lgtm |
LGTM label has been added. Git tree hash: be7e1d85591934234db91f4dc1d54a694e635442
|
/assign @fabriziopandini |
// IsAllowedPath returns true when the Path is one of the AllowedPaths. | ||
func IsAllowedPath(allowedPaths []contract.Path) func(path contract.Path) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// IsAllowedPath returns true when the Path is one of the AllowedPaths. | |
func IsAllowedPath(allowedPaths []contract.Path) func(path contract.Path) bool { | |
// IsPathAllowed returns true when the Path is one of the AllowedPaths. | |
func IsPathAllowed(allowedPaths []contract.Path) func(path contract.Path) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these functions where not introduced in this package and just migrated from another internal package I would like to move this discussion into a follow-up issue to unblock this PR.
Since these functions are internal we are safe to change them in a follow-up.
I added a follow-up item for this in the umbrella issue.
(Same for the other ssa util review comments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to fix this/similar methods in a follow-up now that those methods are part of our internal utils
b4addaa
to
f405b5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
/lgtm
/approve
/hold
For @ykakarap @sbueringer to evaluate my question above
LGTM label has been added. Git tree hash: b3b5256896ad3f2ff1f02e624ea00eb5fee11404
|
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest |
What this PR does / why we need it:
This PR adds in-place propagation support for labels and annotation from MachineSet to InfraMachine and BootstrapConfig.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Part of #7731