Rename internal/util/ssa util functions for better naming consistency

[ykakarap]

Detailed Description:

Rename the following functions in the ssa package to have consistent naming scheme:

• IsAllowedPath -> IsPathAllowed (Ref)
• IsIgnorePath -> IsPathIgnored (Ref)
• IsNotAllowed -> IsPathNotAllowed (Ref)

All the above functions are in internal/util/ssa package.

The comments on these functions should also be corrected. Example:
For IsAllowedPath the comment should be changed to // IsAllowedPath returns a functions that returns true when the Path is one of the AllowedPaths. (similarly for the other functions).

Additional Information:
We need to have an explicit IsPathNotAllowed and cannot simple use the negation of IsPathAllowed and ask used to use !IsPathAllowed() as both the functions return a filter function and there is no simple way to get to negation of the returned function.

/kind cleanup
/help

[k8s-ci-robot]

@ykakarap:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Detailed Description:

Rename the following functions in the ssa package to have consistent naming scheme:

• IsAllowedPath -> IsPathAllowed (Ref)
• IsIgnorePath -> IsPathIgnored (Ref)
• IsNotAllowed -> IsPathNotAllowed (Ref)

All the above functions are in internal/util/ssa package.

The comments on these functions should also be corrected. Example:
For IsAllowedPath the comment should be changed to // IsAllowedPath returns a functions that returns true when the Path is one of the AllowedPaths. (similarly for the other functions).

Additional Information:
We need to have an explicit IsPathNotAllowed and cannot simple use the negation of IsPathAllowed and ask used to use !IsPathAllowed() as both the functions return a filter function and there is no simple way to get to negation of the returned function.

/kind cleanup
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fabriziopandini]

/triage accepted
/good-first-issue

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cahillsf]

hey @ykakarap 👋 I'd like to pick this one up

[killianmuldoon]

/assign @cahillsf

Thanks!
(I think you should be able to assign yourself with a command like the above)