⚠️ in-place propagation from MS to Machines #8111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
reviewed
Feb 21, 2023
|
@ykakarap I think the findings are mostly nits, let's fix them up and get ready for merge :) (please also note/fix the golangci-lint findings) |
|
/test pull-cluster-api-e2e-full-main |
|
Independent flake /test pull-cluster-api-e2e-full-main |
ykakarap
force-pushed
the
node-label-in-place-propagation_ms-machines
branch
from
87293fe
to
e81b680
Compare
|
/test pull-cluster-api-e2e-full-main |
19 tasks
|
Great work!! /lgtm /assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 82621a8d619bca2c19adeeba66ed4c7a64efa67e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the in-place propagation behavior for MachineSets. Changes to in-place propagation fields in MachineSet are synced to the target Machines.
Follow-up work:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Part of #7731