Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint to v1.55.2 #9589

Closed
killianmuldoon opened this issue Oct 20, 2023 · 11 comments
Closed

Update golangci-lint to v1.55.2 #9589

killianmuldoon opened this issue Oct 20, 2023 · 11 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

Golangci-lint has a new release - v1.55.0

The release notes are here: https://github.com/golangci/golangci-lint/releases/tag/v1.55.0

After doing an initial test it looks like there's a bunch of new findings - some of them likely spurious and better to ignore. CAPI should update to the new version when possible.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 20, 2023
@killianmuldoon
Copy link
Contributor Author

/help
/triage accepted

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 20, 2023
@adityabhatia
Copy link
Contributor

/assign

@killianmuldoon killianmuldoon changed the title Update golangci-lint to v1.55.0 Update golangci-lint to v1.55.1 Oct 25, 2023
@killianmuldoon
Copy link
Contributor Author

Note v1.55.1 has now been released.

@chiukapoor
Copy link
Contributor

@adityabhatia are you working on it? If not may I take this over?

@adityabhatia
Copy link
Contributor

@adityabhatia are you working on it? If not may I take this over?

Thanks for the offer @chiukapoor, I will take care of this.

@chrischdi
Copy link
Member

The PR got merged and this is done right?

However, there is already v1.55.2

@furkatgofurov7
Copy link
Member

/retitle Update golangci-lint to v1.55.2

@adityabhatia do you want to take care of it again? If not, feel free to unassign, thanks!

@k8s-ci-robot k8s-ci-robot changed the title Update golangci-lint to v1.55.1 Update golangci-lint to v1.55.2 Nov 20, 2023
@adityabhatia
Copy link
Contributor

@furkatgofurov7 I can take this

@killianmuldoon
Copy link
Contributor Author

/close

This should be done in #9740

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Closing this issue.

In response to this:

/close

This should be done in #9740

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants