🌱 Bump golangci-lint to v1.55.1

[adityabhatia]

What this PR does / why we need it:
This PR bumps the golangci-lint from v1.54.1 -> v1.55.1

The major changes proposed in this PR include version updates to the following linters:
gosec - G601: Implicit memory aliasing in for loop.
goconst - string xyz has X occurrences, make it a constant

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #9589

[k8s-ci-robot]

Hi @adityabhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adityabhatia]

For the goconst linter, tests had to be excluded, since the number of re-used occurrences of strings > 3 resulted in a relatively large amount of lint issues. These can be fixed, however I believe these strings enhance the readability of the individual test cases.
E.g. https://github.com/kubernetes-sigs/cluster-api/blob/main/bootstrap/kubeadm/types/utils_test.go#L260

[killianmuldoon]

For the goconst linter, tests had to be excluded, since the number of re-used occurrences of strings > 3 resulted in a relatively large amount of lint issues. These can be fixed, however I believe these strings enhance the readability of the individual test cases.

Could you open up a follow-up issue to decide how to handle this going forward. It's good to have as a nudge IMO, and we could set it to 5 or 8 or something to make it less impactful. But let's take it to a new issue and continue with this one as-is.

[killianmuldoon]

/area dependency

/ok-to-test

[adityabhatia]

For the goconst linter, tests had to be excluded, since the number of re-used occurrences of strings > 3 resulted in a relatively large amount of lint issues. These can be fixed, however I believe these strings enhance the readability of the individual test cases.

Could you open up a follow-up issue to decide how to handle this going forward. It's good to have as a nudge IMO, and we could set it to 5 or 8 or something to make it less impactful. But let's take it to a new issue and continue with this one as-is.

Sure - I wanted to check what other had to say, before formulating this issue.

[vincepri]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2499ed767b3473566f2b15d3facd1eacb4a6a575

[killianmuldoon]

One nit and this is good to go - thanks!

[killianmuldoon]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 44a4db009d6036a5d92867ebef25126a64b45afd

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment