Re-enable goconst linter for test files

[adityabhatia]

In this PR goconst linter was disabled for test files - to exclude test files from creating lint issues, for a string value with > 3 occurrences.

However most of these string values in test files enhance the readability if the respective test cases. E.g. https://github.com/kubernetes-sigs/cluster-api/blob/main/bootstrap/kubeadm/types/utils_test.go#L260

The linter should not be completely excluded for tests in the long term.
A solution to either fix all lint issues or increase the occurrence default value should be implemented.

[killianmuldoon]

/triage accepted

Thanks!

[killianmuldoon]

/help

First steps to figure this out are to try some of the other configuration options for goconst and see what the tradeoffs are.

[k8s-ci-robot]

@killianmuldoon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

First steps to figure this out are to try some of the other configuration options for goconst and see what the tradeoffs are.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

Increase the occurrence default value should be implemented.

Sounds reasonable

[vincepri]

fwiw, I'm fine, for tests, to have this disabled

[vincepri]

Closing this, no need to have constants in tests unless absolutely necessary.

/close

[k8s-ci-robot]

@vincepri: Closing this issue.

In response to this:

Closing this, no need to have constants in tests unless absolutely necessary.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.