Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] 🌱 improve release-staging build #10190

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Feb 22, 2024

What this PR does / why we need it:
Backport of #10095

removes the docker-image-verify sub-make from release-staging as the PR introducing it was not backported

/area release

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2024
@cahillsf cahillsf changed the title improve release-staging build [release-1.6] 🌱 improve release-staging build Feb 22, 2024
@cahillsf
Copy link
Member Author

cahillsf commented Feb 22, 2024

can backport this too if we want to make it a "clean" cherry-pick: #9932 - lmk

will do the same for release-1.5 once I have feedback on the above

@cahillsf cahillsf marked this pull request as ready for review February 22, 2024 01:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@cahillsf
Copy link
Member Author

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing and removed do-not-merge/needs-area PR is missing an area label labels Feb 28, 2024
@chrischdi
Copy link
Member

/hold

did not get cherry-picked if I see it correctly?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@cahillsf
Copy link
Member Author

/hold

did not get cherry-picked if I see it correctly?

ah! That is definitely true, thank you for catching

@cahillsf
Copy link
Member Author

tying together, two followup PRs to ensure the workaround is backported prior to backporting the parallelization:

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

The dockerfile from sdtin PRs should merge this morning - feel free to unhold this one once that's through.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2e0ac108bae64f64f8ceed388473e095f7d15772

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@cahillsf
Copy link
Member Author

cahillsf commented Mar 5, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@cahillsf
Copy link
Member Author

cahillsf commented Mar 5, 2024

opened one more to back port into release-1.5 when you have a chance to take a look @killianmuldoon @chrischdi 🙇

#10227

@k8s-ci-robot k8s-ci-robot merged commit 48d2c6c into kubernetes-sigs:release-1.6 Mar 5, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants