-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 read in dockerfiles from stdin #9990
🌱 read in dockerfiles from stdin #9990
Conversation
Skipping CI for Draft Pull Request. |
waiting for this PR to be approved/merged then will take out of draft: https://github.com/kubernetes-sigs/cluster-api/pull/9932/files |
/lgtm |
LGTM label has been added. Git tree hash: f21d817c9197cc9812ae07b252f92c48e5ef63d6
|
28a40ad
to
8cd92af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 03c7ee9fc6d8e506cb21a2a8449081a9e7a7e4d6
|
Thx! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area ci EDIT: wrong issue... |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/remove-area ci |
/cherry-pick release-1.6 |
@cahillsf: new pull request created: #10209 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.5 |
@cahillsf: #9990 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
this implements the workaround mentioned here: moby/buildkit#1368 (comment) for avoiding an incorrectly cached Dockerfile
All of the unmodifiedchange has been applied to each build targetdocker-build-*
targets leverage the--build-arg package
option and intentionally use the same Dockerfile located in the root dirWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9752
details of findings in this comment: #9752 (comment)
/area release