🌱 Fix CRS e2e helper with multiple bindings #10191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/area e2e-testing |
k8s-ci-robot
added
area/e2e-testing
jimmidyson
changed the title
jimmidyson
force-pushed
the
jimmi/e2e-test-crs-binding-check
branch
3 times, most recently
from
bbfb1ef
to
45b38cc
Compare
k8s-ci-robot
added
size/XS
chrischdi
reviewed
Feb 22, 2024
jimmidyson
force-pushed
the
jimmi/e2e-test-crs-binding-check
branch
from
45b38cc
to
f21b253
Compare
k8s-ci-robot
added
size/S
Check the relevant ResourceSetBinding to see if the resource is applied. If multiple ClusterResourceSets match a cluster, the ClusterResourceSetBinding will have multiple bindings and so only the relevant ResourceSetBinding should be checked.
jimmidyson
force-pushed
the
jimmi/e2e-test-crs-binding-check
branch
from
f21b253
to
78e9c3f
Compare
chrischdi
reviewed
Feb 23, 2024
|
Thanks for your reviews @chrischdi! I've applied your suggestions. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 21eac5de9689f3b912402156c23bfc82fbe4741d
|
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/L
I've added a test for the utility function but not for the full helper as that will be a lot more involved. I don't see tests for any of the other helpers so hope that's ok. Let me know what you think. 🙏 |
|
@vincepri @chrischdi Would you be able to take another look please? 🙏 |
chrischdi
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ffe0051d457154c63ed9c68d543479d93275c821
|
|
Thanks for fixing this! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
* test(e2e): Fix CRS helper with multiple bindings Check the relevant ResourceSetBinding to see if the resource is applied. If multiple ClusterResourceSets match a cluster, the ClusterResourceSetBinding will have multiple bindings and so only the relevant ResourceSetBinding should be checked. * fixup! refactor: Apply review suggestions * fixup! test: Add test for CRS e2e helper
Dhairya-Arora01
pushed a commit
to Dhairya-Arora01/cluster-api
that referenced
this pull request
May 25, 2024
* test(e2e): Fix CRS helper with multiple bindings Check the relevant ResourceSetBinding to see if the resource is applied. If multiple ClusterResourceSets match a cluster, the ClusterResourceSetBinding will have multiple bindings and so only the relevant ResourceSetBinding should be checked. * fixup! refactor: Apply review suggestions * fixup! test: Add test for CRS e2e helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all bindings to see if the resource is applied. If multiple ClusterResourceSets match a cluster, the ClusterResourceSetBinding will have multiple bindings and so only the ResourceSetBinding related to the specific ClusterResourceSet must be checked.
I discovered this when using the e2e test framework in an external project that applied multiple ClusterResourceSets to a cluster as part of the e2e tests.