Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Release v1.6.3 #10252

Merged
merged 1 commit into from
Mar 12, 2024
Merged

🌱 Release v1.6.3 #10252

merged 1 commit into from
Mar 12, 2024

Conversation

willie-yao
Copy link
Contributor

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2024
fabriziopandini
fabriziopandini reviewed Mar 11, 2024
View reviewed changes
CHANGELOG/v1.6.3.md

:book: Additionally, there have been 3 contributions to our documentation and book. (#10230, #10241, #10243)

## Dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop this or add a "No dependency changes in this release" statement?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Q: Why is this section empty? We have a bump in l.22

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was updated with the force push just a few minutes ago: https://github.com/kubernetes-sigs/cluster-api/pull/10252/files#r1521783375

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that look right you @sbueringer ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Sorry I think I missed the sub sections :)

@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@cahillsf
Copy link
Member

/hold

same as: #10251 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@cahillsf
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 177d36e8bcfaf9efb0a239adb239feff66ce4ce8

@nawazkh
Copy link
Member

nawazkh commented Mar 12, 2024

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit c3298d1 into kubernetes-sigs:main Mar 12, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@cahillsf cahillsf cahillsf left review comments

@troy0820 troy0820 Awaiting requested review from troy0820

@yrs147 yrs147 Awaiting requested review from yrs147

Assignees

@nawazkh nawazkh

@cahillsf cahillsf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@willie-yao @fabriziopandini @k8s-ci-robot @cahillsf @nawazkh @sbueringer