-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 bump docker/docker to 26.0.0+incompatible #10335
Conversation
Hi @kranurag7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bumps github.com/docker/docker from 25.0.5+incompatible to 26.0.0+incompatible Signed-off-by: Anurag <contact.anurag7@gmail.com>
b80d05e
to
b617bb3
Compare
/ok-to-test |
As of now the PR is identical to the dependabot PR, we'll have to make some adjustments :) |
Ahh, fixed the lints via ddf1394 Details
# make lint
fatal: No names found, cannot describe anything.
/root/cluster-api/hack/tools/bin/golangci-lint-v1.56.1 run -v
INFO [config_reader] Config search paths: [./ /root/cluster-api /root /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 43 linters: [asasalint asciicheck bidichk bodyclose containedctx dogsled dupword durationcheck errcheck errchkjson exportloopref gci ginkgolinter goconst gocritic godot gofmt goimports goprintffuncname gosec gosimple govet importas ineffassign loggercheck misspell nakedret nilerr noctx nolintlint nosprintfhostport prealloc predeclared revive rowserrcheck staticcheck stylecheck thelper unconvert unparam unused usestdlibvars whitespace]
INFO [loader] Using build tags: [tools e2e]
INFO [loader] Go packages loading at mode 575 (name|types_sizes|compiled_files|deps|exports_file|imports|files) took 882.157451ms
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 82.116293ms
INFO [linters_context/goanalysis] analyzers took 0s with no stages
INFO [runner] Issues before processing: 2211, after processing: 0
INFO [runner] Processors filtering stat (out/in): path_prettifier: 2211/2211, skip_dirs: 757/757, filename_unadjuster: 2211/2211, skip_files: 757/2211, nolint: 0/109, cgo: 2211/2211, autogenerated_exclude: 757/757, identifier_marker: 757/757, exclude: 757/757, exclude-rules: 109/757
INFO [runner] processing took 61.621175ms with stages: nolint: 21.771544ms, exclude-rules: 15.25818ms, identifier_marker: 13.332794ms, autogenerated_exclude: 5.442011ms, path_prettifier: 3.952672ms, skip_dirs: 851.761µs, skip_files: 829.141µs, cgo: 124.141µs, filename_unadjuster: 56.261µs, max_same_issues: 790ns, severity-rules: 340ns, exclude: 310ns, fixer: 280ns, sort_results: 200ns, uniq_by_line: 140ns, max_from_linter: 130ns, diff: 110ns, source_code: 110ns, path_shortener: 100ns, max_per_file_from_linter: 90ns, path_prefixer: 70ns
INFO [runner] linters took 485.662568ms with stages: goanalysis_metalinter: 423.966332ms
INFO File cache stats: 22 entries of total size 102.8KiB
INFO Memory: 16 samples, avg is 52.9MB, max is 113.1MB
INFO Execution took 1.456802211s
cd test; /root/cluster-api/hack/tools/bin/golangci-lint-v1.56.1 run --path-prefix test --config /root/cluster-api/.golangci.yml -v
INFO [config_reader] Used config file ../.golangci.yml
INFO [lintersdb] Active 43 linters: [asasalint asciicheck bidichk bodyclose containedctx dogsled dupword durationcheck errcheck errchkjson exportloopref gci ginkgolinter goconst gocritic godot gofmt goimports goprintffuncname gosec gosimple govet importas ineffassign loggercheck misspell nakedret nilerr noctx nolintlint nosprintfhostport prealloc predeclared revive rowserrcheck staticcheck stylecheck thelper unconvert unparam unused usestdlibvars whitespace]
INFO [loader] Using build tags: [tools e2e]
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|imports|name|types_sizes|deps|files) took 571.52796ms
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 27.328798ms
INFO [linters_context/goanalysis] analyzers took 0s with no stages
INFO [runner] Issues before processing: 649, after processing: 0
INFO [runner] Processors filtering stat (out/in): skip_dirs: 543/543, identifier_marker: 543/543, filename_unadjuster: 649/649, skip_files: 543/649, autogenerated_exclude: 543/543, exclude: 543/543, exclude-rules: 107/543, nolint: 0/107, cgo: 649/649, path_prettifier: 649/649
INFO [runner] processing took 41.517792ms with stages: nolint: 17.285885ms, exclude-rules: 12.207609ms, identifier_marker: 7.972035ms, autogenerated_exclude: 1.967546ms, path_prettifier: 1.317957ms, skip_dirs: 436.645µs, skip_files: 261.514µs, cgo: 50.281µs, filename_unadjuster: 15.57µs, max_same_issues: 710ns, exclude: 380ns, severity-rules: 370ns, fixer: 300ns, uniq_by_line: 220ns, sort_results: 190ns, source_code: 120ns, max_from_linter: 120ns, max_per_file_from_linter: 100ns, diff: 90ns, path_prefixer: 80ns, path_shortener: 70ns
INFO [runner] linters took 623.619631ms with stages: goanalysis_metalinter: 582.035027ms
INFO File cache stats: 27 entries of total size 272.7KiB
INFO Memory: 14 samples, avg is 59.9MB, max is 116.8MB
INFO Execution took 1.229022204s
cd hack/tools; /root/cluster-api/hack/tools/bin/golangci-lint-v1.56.1 run --path-prefix hack/tools --config /root/cluster-api/.golangci.yml -v
INFO [config_reader] Used config file ../../.golangci.yml
INFO [lintersdb] Active 43 linters: [asasalint asciicheck bidichk bodyclose containedctx dogsled dupword durationcheck errcheck errchkjson exportloopref gci ginkgolinter goconst gocritic godot gofmt goimports goprintffuncname gosec gosimple govet importas ineffassign loggercheck misspell nakedret nilerr noctx nolintlint nosprintfhostport prealloc predeclared revive rowserrcheck staticcheck stylecheck thelper unconvert unparam unused usestdlibvars whitespace]
INFO [loader] Using build tags: [tools e2e]
INFO [loader] Go packages loading at mode 575 (compiled_files|deps|exports_file|types_sizes|files|imports|name) took 462.358373ms
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 1.867164ms
INFO [linters_context/goanalysis] analyzers took 0s with no stages
INFO [runner] Issues before processing: 62, after processing: 0
INFO [runner] Processors filtering stat (out/in): filename_unadjuster: 62/62, exclude: 26/26, identifier_marker: 26/26, exclude-rules: 18/26, nolint: 0/18, cgo: 62/62, skip_dirs: 26/26, autogenerated_exclude: 26/26, path_prettifier: 62/62, skip_files: 26/62
INFO [runner] processing took 7.027301ms with stages: nolint: 4.861373ms, exclude-rules: 851.151µs, identifier_marker: 676.469µs, autogenerated_exclude: 275.704µs, path_prettifier: 177.362µs, skip_dirs: 104.711µs, skip_files: 63.181µs, cgo: 8.18µs, filename_unadjuster: 5.83µs, max_same_issues: 600ns, severity-rules: 490ns, fixer: 320ns, uniq_by_line: 320ns, exclude: 300ns, diff: 240ns, max_from_linter: 210ns, source_code: 190ns, sort_results: 190ns, max_per_file_from_linter: 170ns, path_shortener: 160ns, path_prefixer: 150ns
INFO [runner] linters took 541.431667ms with stages: goanalysis_metalinter: 534.311244ms
INFO File cache stats: 0 entries of total size 0B
INFO Memory: 12 samples, avg is 57.3MB, max is 96.6MB
INFO Execution took 1.010080053s
./scripts/ci-lint-dockerfiles.sh v2.12.0 warning
Linting: cmd/clusterctl/Dockerfile
Linting: Dockerfile
Linting: test/extension/Dockerfile
Linting: test/infrastructure/inmemory/Dockerfile
Linting: test/infrastructure/docker/Dockerfile |
/lgtm |
LGTM label has been added. Git tree hash: a2954cbfc1bbfb1d71917fa9277827c9ec29ce30
|
/approve |
/approve cancel (wrong PR, let another one approve) |
/area dependency |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
manually bumps github.com/docker/docker from 25.0.5+incompatible to 26.0.0+incompatible
Ref: #10322
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #