Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Release v1.7.0-rc.1 #10395

Merged
merged 1 commit into from
Apr 9, 2024
Merged

🌱 Release v1.7.0-rc.1 #10395

merged 1 commit into from
Apr 9, 2024

Conversation

typeid
Copy link
Contributor

@typeid typeid commented Apr 8, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @typeid. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2024
@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch from 35b3c8a to 21ca176 Compare April 8, 2024 15:00
@typeid typeid changed the title Release v1.7.0-rc.1 🌱 Release v1.7.0-rc.1 Apr 8, 2024
@typeid
Copy link
Contributor Author

typeid commented Apr 8, 2024

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing and removed do-not-merge/needs-area PR is missing an area label labels Apr 8, 2024
chrischdi
chrischdi reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misses the latest cherry-pick from:

#10393

Don't know if this gets updated again :-)

@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch from 21ca176 to a8d5e53 Compare April 8, 2024 15:41
@typeid
Copy link
Contributor Author

typeid commented Apr 8, 2024

@chrischdi I re-generated to add #10393 :)

@chrischdi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2024
@typeid
Copy link
Contributor Author

typeid commented Apr 8, 2024

For the broken link.. should it be https://github.com/go-gl/glfw/compare/6f7a984..12ad95a instead of go-gl/glfw@v3.3/glfw/6f7a984...v3.3/glfw/12ad95a?

@willie-yao
Copy link
Contributor

@typeid The broken link is just an issue with that specific package. We decided to remove that line in the previous release notes #10253 (comment)

@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch from a8d5e53 to 3d167e0 Compare April 8, 2024 17:03
willie-yao
willie-yao reviewed Apr 8, 2024
View reviewed changes
CHANGELOG/v1.7.0-rc.1.md Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.0-rc.1.md Show resolved Hide resolved
@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch from 0338b7d to e5c8f03 Compare April 8, 2024 18:18
willie-yao
willie-yao approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks good! We'll probably need to regenerate the notes tomorrow in case anything new merges. You can probably just add any new commits manually since you already did the work cleaning everything up. Great work on this! 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 571b03bdc7415d11b18a9dc7deea2bf09d2e71b7

cahillsf
cahillsf reviewed Apr 8, 2024
View reviewed changes
CHANGELOG/v1.7.0-rc.1.md Outdated Show resolved Hide resolved
@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch from e5c8f03 to 8869902 Compare April 9, 2024 06:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2024
@adilGhaffarDev
Copy link
Contributor

@typeid these are the commits done after the notes generation:

Can you add them manually?

@adilGhaffarDev
Copy link
Contributor

@typeid This one is also merging soon:
#10409

@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch 2 times, most recently from 003d1a0 to 9707583 Compare April 9, 2024 17:01
willie-yao
willie-yao reviewed Apr 9, 2024
View reviewed changes
CHANGELOG/v1.7.0-rc.1.md Outdated
- CI: Change base branch for link checker (#10365)
- Dependency: Bump golang to v1.21.9 and golang.org/x/net to mitigate CVE-2023-45288 (#10378)
- Dependency: Bump sigs.k8s.io/controller-runtime from 0.17.2 to 0.17.3 (#10406)
- Release: Release notes: also detect alpha releases as pre releases (#10379)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Release: Release notes: also detect alpha releases as pre releases (#10379)
- Release: also detect alpha releases as pre releases (#10379)

@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch from 9707583 to 0916ff3 Compare April 9, 2024 17:03
@typeid typeid force-pushed the release-notes-v1.7.0-rc.1 branch from 0916ff3 to 252d6a9 Compare April 9, 2024 17:06
@cahillsf
Copy link
Member

cahillsf commented Apr 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ab89ebc17c94b4891c76ed5add0e04d98f464e1f

willie-yao
willie-yao approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sunnatillo
Sunnatillo reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cahillsf
Copy link
Member

cahillsf commented Apr 9, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahillsf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6ba1a88 into kubernetes-sigs:main Apr 9, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 9, 2024
@adilGhaffarDev adilGhaffarDev mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@cahillsf cahillsf cahillsf left review comments

@willie-yao willie-yao willie-yao approved these changes

@troy0820 troy0820 Awaiting requested review from troy0820

@yrs147 yrs147 Awaiting requested review from yrs147

Assignees

@willie-yao willie-yao

@cahillsf cahillsf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@typeid @k8s-ci-robot @chrischdi @willie-yao @adilGhaffarDev @cahillsf @Sunnatillo