-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Release v1.7.0-rc.1 #10395
🌱 Release v1.7.0-rc.1 #10395
Conversation
Hi @typeid. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
35b3c8a
to
21ca176
Compare
/area release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21ca176
to
a8d5e53
Compare
@chrischdi I re-generated to add #10393 :) |
/ok-to-test |
For the broken link.. should it be https://github.com/go-gl/glfw/compare/6f7a984..12ad95a instead of go-gl/glfw@v3.3/glfw/6f7a984...v3.3/glfw/12ad95a? |
@typeid The broken link is just an issue with that specific package. We decided to remove that line in the previous release notes #10253 (comment) |
a8d5e53
to
3d167e0
Compare
0338b7d
to
e5c8f03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks good! We'll probably need to regenerate the notes tomorrow in case anything new merges. You can probably just add any new commits manually since you already did the work cleaning everything up. Great work on this! 🚀
LGTM label has been added. Git tree hash: 571b03bdc7415d11b18a9dc7deea2bf09d2e71b7
|
e5c8f03
to
8869902
Compare
@typeid these are the commits done after the notes generation:
Can you add them manually? |
003d1a0
to
9707583
Compare
CHANGELOG/v1.7.0-rc.1.md
Outdated
- CI: Change base branch for link checker (#10365) | ||
- Dependency: Bump golang to v1.21.9 and golang.org/x/net to mitigate CVE-2023-45288 (#10378) | ||
- Dependency: Bump sigs.k8s.io/controller-runtime from 0.17.2 to 0.17.3 (#10406) | ||
- Release: Release notes: also detect alpha releases as pre releases (#10379) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Release: Release notes: also detect alpha releases as pre releases (#10379) | |
- Release: also detect alpha releases as pre releases (#10379) |
9707583
to
0916ff3
Compare
0916ff3
to
252d6a9
Compare
/lgtm |
LGTM label has been added. Git tree hash: ab89ebc17c94b4891c76ed5add0e04d98f464e1f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahillsf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.