Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release v1.8.0-beta.0 #10864

Merged
merged 1 commit into from
Jul 16, 2024
Merged

🚀 Release v1.8.0-beta.0 #10864

merged 1 commit into from
Jul 16, 2024

Conversation

vishalanarase
Copy link
Member

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2024
chandankumar4
chandankumar4 reviewed Jul 16, 2024
View reviewed changes
CHANGELOG/v1.8.0-beta.0.md Outdated
- ClusterResourceSet: Crs: use separate cache for partial metadata watches on secrets to include all secrets (#10633)
- Dependency: Use k8s.io/utils/ptr instead of k8s.io/utils/pointer (#10700)
- e2e: Fix kubetest to allow parallel execution on different clusters (#10424)
- e2e: Kubetest: also gather junit reports in case of errors observed from ginkgo (#10493)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- e2e: Kubetest: also gather junit reports in case of errors observed from ginkgo (#10493)
- e2e: Kubetest also gather junit reports in case of errors observed from ginkgo (#10493)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalanarase @chandankumar4 Let's please keep these kind of colons the next time. It breaks the readability otherwise

chandankumar4
chandankumar4 reviewed Jul 16, 2024
View reviewed changes
CHANGELOG/v1.8.0-beta.0.md Outdated
- Devtools: Bump Cluster API Visualizer to v1.3.0 (#10386)
- Devtools: Bump Cluster API Visualizer to v1.3.1 (#10816)
- Devtools: Improve triage query (#10644)
- Devtools: Tilt: ensure in-tree providers always use start.sh to allow restarts (#10811)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Devtools: Tilt: ensure in-tree providers always use start.sh to allow restarts (#10811)
- Devtools: Ensure in-tree providers always use start.sh to allow restarts (#10811)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't drop information like this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we're trying to only have one colon, but while achieving this we're reducing the amount of information and readability

@sbueringer
Copy link
Member

We'll probably have to re-generate later (or at least add newly merged PRs)

@vishalanarase
Copy link
Member Author

We'll probably have to re-generate later (or at least add newly merged PRs)

@sbueringer Done

@sbueringer
Copy link
Member

Mostly only reviewed the supported versions, just don't have the time to review the entire release notes this time around (will spend more time on it towards RC / GA)

@adilGhaffarDev
Copy link
Contributor

add this one too, #10873 , it merged recently.

@sbueringer
Copy link
Member

sbueringer commented Jul 16, 2024 •
edited

I've put hold on a few PRs, I hope we're good once we added the ones mentioned above

@vishalanarase
🚀 Release v1.8.0-beta.0
0bf0d86 
Signed-off-by: Vishal Anarase <iamvishalanarase@gmail.com>
@vishalanarase
Copy link
Member Author

add this one too, #10873 , it merged recently.

Addded

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f14169798499006bf83f2cdc16d5740934babf6a

@adilGhaffarDev
Copy link
Contributor

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adilGhaffarDev
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
Sunnatillo
Sunnatillo reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot merged commit 377bd19 into kubernetes-sigs:main Jul 16, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jul 16, 2024
@sbueringer
Copy link
Member

Q: Should we just not add MULTIPLE_AREAS when we generate the release notes? Looks like we first generate it and then just drop it manually

sbueringer
sbueringer reviewed Jul 19, 2024
View reviewed changes
CHANGELOG/v1.8.0-beta.0.md
Comment on lines +180 to +182
- Release: Release v1.5.8 (#10438)
- Release: Release v1.6.4 (#10439)
- Release: Release v1.7.0 (#10440)
Copy link
Member

@sbueringer sbueringer Jul 19, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 should not show up. I would have expected them to be filtered out by the release not tool (I thought we implemented it already)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am checking why we are seeing these here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very strange for some reason the implementation did not work for these three PRs, I can see that it has been able to ignore all other release note PRs. I am checking what is different with these three PRs
cc @chandankumar4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that it might be because they have 🌱 in the title instead of 🚀 , but this release note PR(#10395) is ignored and it also has 🌱 in the title. So that's not the reason something else is different there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll look it more closely and will open up an issue with detail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for following-up! Just noticed it and was surprised.

I thought in general these PRs must have 🚀 in the title

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we started doing it after 1.7.0 ,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chandankumar4 chandankumar4 chandankumar4 approved these changes

@Sunnatillo Sunnatillo Sunnatillo left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@pravarag pravarag Awaiting requested review from pravarag

Assignees

@sbueringer sbueringer

@adilGhaffarDev adilGhaffarDev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vishalanarase @sbueringer @adilGhaffarDev @k8s-ci-robot @chandankumar4 @Sunnatillo