🐛 Cluster should be provisoned when cpRef and endpoint is set #10873
Conversation
|
/area cluster |
k8s-ci-robot
added
the
cncf-cla: yes
|
@vincepri: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/needs-area
|
/cherry-pick release-1.7 |
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We're currently treating the infrastructureRef as almost a requirement, which in fact isn't and it's an optional reference. If the Cluster control plane reference is populated, the endpoint is valid, and the control plane is ready, set the phase to provisioned Signed-off-by: Vince Prignano <vince@prigna.com>
vincepri
force-pushed
the
bug-cluster-phase-cp
branch
from
5e9ba63
to
a6e73ad
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 02b04b4ec24f48683d37789cdc5c39f7e85e4a21
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@vincepri: new pull request created: #10881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Also on main, looks like this broke kcp remediation e2e tests in https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-e2e-mink8s-main |
|
@vincepri Can you please look into this? |
We're currently treating the infrastructureRef as almost a requirement, which in fact isn't and it's an optional reference.
If the Cluster control plane reference is populated, the endpoint is valid, and the control plane is ready, set the phase to provisioned
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #