🌱 Partially revert changes for ":bug: Cluster should be provisoned when cpRef and endpoint is set" #10903
Conversation
… cpRef and endpoint is set"
k8s-ci-robot
added
area/api
|
/test pull-cluster-api-e2e-main |
|
/lgtm Thx for fixing this! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 304807d417099b293048613134d4722d6f14a896
|
|
I'll take the "review approval" as approval :) /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.7 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sbueringer: new pull request created: #10904 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR is a small improvement on changes introduced by #10873, making sure that cluster provisioned phase isn't including control plane fully ready (which was altering the original semantic of those phases)
Also improved the go comments for the phase const to better reflect current state
Which issue(s) this PR fixes:
Fixes #10885
/area api
cc @vincepri