Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.7] 🐛 Cluster should be provisoned when cpRef and endpoint is set #10881

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #10873

/assign vincepri

We're currently treating the infrastructureRef as almost a requirement,
which in fact isn't and it's an optional reference.

If the Cluster control plane reference is populated, the endpoint is
valid, and the control plane is ready, set the phase to provisioned

Signed-off-by: Vince Prignano <vince@prigna.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2024
@vincepri vincepri added the area/api Issues or PRs related to the APIs label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 16, 2024
@vincepri
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 95251b06f5465a2e96a27f7fae8dbda33620fa83

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit b27e18e into kubernetes-sigs:release-1.7 Jul 16, 2024
23 checks passed
@chrischdi
Copy link
Member

chrischdi commented Jul 17, 2024

Looks like this broke KCP remediation e2e tests on capi-e2e-mink8s-release-1-7

https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-1.7#capi-e2e-mink8s-release-1-7

Full diff: eb19a98...b27e18e?

So could also have been

But unlikely from context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants