Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 clusterctl: ensure cert-manager objects get applied before other provider objects #10469

Merged

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Apr 19, 2024

What this PR does / why we need it:

  • clusterctl: ensure cert-manager objects get applied before other provider objects, but after creating the namespace
  • test: wait for ca injection in case we use an external clusterctl binary for upgrading

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

part of #9688

supersedes #10433

/area clusterctl

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2024
@chrischdi chrischdi force-pushed the pr-cert-manager-fix-x509-errors branch from 047c6ae to e3e6558 Compare April 19, 2024 15:17
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2024
@chrischdi chrischdi force-pushed the pr-cert-manager-fix-x509-errors branch 6 times, most recently from 44e5c88 to 9cbb18b Compare April 23, 2024 13:39
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some smaller findings

test/framework/clusterctl/ca_injection.go Outdated Show resolved Hide resolved
test/framework/clusterctl/ca_injection.go Outdated Show resolved Hide resolved
test/framework/clusterctl/ca_injection.go Outdated Show resolved Hide resolved
test/framework/clusterctl/ca_injection.go Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-cert-manager-fix-x509-errors branch from 9cbb18b to 41b9c4a Compare April 23, 2024 14:24
@chrischdi chrischdi changed the title [WIP] 🐛 clusterctl: ensure cert-manager objects get applied before other provider objects 🐛 clusterctl: ensure cert-manager objects get applied before other provider objects Apr 23, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
@chrischdi chrischdi changed the title 🐛 clusterctl: ensure cert-manager objects get applied before other provider objects 🐛 clusterctl: ensure cert-manager objects get applied before other provider objects Apr 23, 2024
@chrischdi
Copy link
Member Author

/assign @adilGhaffarDev

Kindly asking for a review, because you have some context on this error case :-)

@sbueringer
Copy link
Member

/ok-to-test
/lgtm
/approve

/hold

for further reviews

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: beb15127aa5dd6c9a70f5468e71a27fdf996ff0d

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@chrischdi chrischdi force-pushed the pr-cert-manager-fix-x509-errors branch from 41b9c4a to 8b33974 Compare April 23, 2024 14:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-dualstack-and-ipv6-main
/test pull-cluster-api-e2e-mink8s-main

@chrischdi
Copy link
Member Author

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…s and wait for ca injection in tests using a clusterctl binary
@chrischdi chrischdi force-pushed the pr-cert-manager-fix-x509-errors branch from 8b33974 to b239b4c Compare April 23, 2024 14:49
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-dualstack-and-ipv6-main
/test pull-cluster-api-e2e-mink8s-main

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3b0aca96e57fe7c665ee3366c86924c9ebfb84e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adilGhaffarDev
Copy link
Contributor

LGTM
Thanks @chrischdi

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7755426 into kubernetes-sigs:main Apr 24, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 24, 2024
@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #10503

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #10504

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants