Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Release v1.7.1 #10488

Merged
merged 1 commit into from
Apr 23, 2024
Merged

🚀 Release v1.7.1 #10488

merged 1 commit into from
Apr 23, 2024

Conversation

chandankumar4
Copy link
Contributor

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chandankumar4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2024
adilGhaffarDev
adilGhaffarDev reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do some manual changes to inform about the support of Kubernetes v1.30.

CHANGELOG/v1.7.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.1.md Outdated Show resolved Hide resolved
CHANGELOG/v1.7.1.md Outdated Show resolved Hide resolved
@adilGhaffarDev
Copy link
Contributor

cc: @chrischdi @sbueringer @fabriziopandini please take a look when you get time.

chrischdi
chrischdi reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the cherry-picks but this one is missing currently:

@sbueringer
Copy link
Member

sbueringer commented Apr 23, 2024 •
edited

Overall looks good so far. Please just regenerate before you release and add the PRs that show up in the delta

(there might be more than the one that Christian linked)

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2024
@chandankumar4 chandankumar4 force-pushed the release-v1.7.1 branch 2 times, most recently from 7d4a26a to a1cadd7 Compare April 23, 2024 16:28
@adilGhaffarDev
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ef092247716435992e4755988b848a3f5b5ba71

@adilGhaffarDev
Copy link
Contributor

@chrischdi can you check again and approve

Sunnatillo
Sunnatillo reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adilGhaffarDev
Copy link
Contributor

@chrischdi can you check again and approve

let's aim to add this one: #10469 in the next patch release. cc: @sbueringer

willie-yao
willie-yao reviewed Apr 23, 2024
View reviewed changes
CHANGELOG/v1.7.1.md Outdated

## :bug: Bug Fixes
- CAPD: Verify lb config after writing it (#10461)
- e2e: Kubetest: also gather junit reports in case of errors observed from ginkgo (#10494)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- e2e: Kubetest: also gather junit reports in case of errors observed from ginkgo (#10494)
- e2e: also gather junit reports in case of errors observed from ginkgo (#10494)

@chandankumar4
🚀 Release v1.7.1
231cd10 
Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@adilGhaffarDev
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2cc104e0da492e26c81080def0761597686000b

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 112ec8c into kubernetes-sigs:main Apr 23, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 23, 2024
@chandankumar4 chandankumar4 deleted the release-v1.7.1 branch August 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@willie-yao willie-yao willie-yao left review comments

@Fedosin Fedosin Awaiting requested review from Fedosin

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees

@adilGhaffarDev adilGhaffarDev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@chandankumar4 @k8s-ci-robot @adilGhaffarDev @sbueringer @chrischdi @Sunnatillo @willie-yao