🌱 Feature gate for old infra machine naming

[lentzi90]

What this PR does / why we need it:

There is a breaking change to the way infra machines are named in v1.7.0. This commit adds a feature gate for getting the old behavior back. It defaults to disabled so the new behavior stays. It is also marked as deprecated so it can be removed in a future minor release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10463 (not entirely but at least it makes it possible to get the old behavior back for now)

/area control-plane/kubeadm
/area machineset

[k8s-ci-robot]

@lentzi90: The label(s) area/control-plane/kubeadm cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

There is a breaking change to the way infra machines are named in v1.7.0. This commit adds a feature gate for getting the old behavior back. It defaults to disabled so the new behavior stays. It is also marked as deprecated so it can be removed in a future minor release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10463 (not entirely but at least it makes it possible to get the old behavior back for now)

/area control-plane/kubeadm
/area machineset

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign killianmuldoon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

/area control-plane-kubeadm

[k8s-ci-robot]

@lentzi90: The label(s) area/control-plane-kubeadm cannot be applied, because the repository doesn't have them.

In response to this:

/area control-plane-kubeadm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lentzi90]

/area provider/control-plane-kubeadm

[lentzi90]

Not sure if this makes sense. I wanted to deprecate it right away since the behavior already changed. However, this means the linter complains that we are using it 😓

[guettli]

lgtm

[lentzi90]

/cc @fabriziopandini

[sbueringer]

/hold
To reach consensus about the general direction on the issue first

[sbueringer]

Sorry, wrong button 😃

[lentzi90]

Replaced by #10511 that targets release-1.7. This makes more sense since the idea is that this would be temporary and go away in v1.8

[lentzi90]

/reopen
After more discussions, we agreed to still target this at main and backport to v1.7. That way we can have it in v1.8 also before removal in v1.9.
I have also updated it now to use a normal flag instead of a feature flag.

[k8s-ci-robot]

@lentzi90: Failed to re-open PR: state cannot be changed. The lentzi90/feature-gate-infra-machine-naming branch was force-pushed or recreated.

In response to this:

/reopen
After more discussions, we agreed to still target this at main and backport to v1.7. That way we can have it in v1.8 also before removal in v1.9.
I have also updated it now to use a normal flag instead of a feature flag.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.