Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Feature gate for old infra machine naming #10511

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

There is a breaking change to the way infra machines are named in v1.7.0. This commit adds a feature gate for getting the old behavior back. It defaults to disabled so the new behavior stays. It is also marked as deprecated so it can be removed in a future minor release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10463 (temporary fix to give more time to adapt)

/area provider/control-plane-kubeadm
/area machineset

@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Apr 25, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/control-plane-kubeadm Issues or PRs related to KCP area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2024
@lentzi90
Copy link
Contributor Author

/hold
To reach consensus about the general direction on the issue first

There is a breaking change to the way infra machines are named in
v1.7.0. This commit adds a feature gate for getting the old behavior
back. It defaults to disabled so the new behavior stays. It is also
marked as deprecated so it can be removed in a future minor release.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90 lentzi90 force-pushed the lentzi90/feature-gate-naming-release-1.7 branch from 8aef20a to 2b09d1d Compare May 3, 2024 06:31
@mdbooth
Copy link
Contributor

mdbooth commented May 7, 2024

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Contributor Author

See #10587

@lentzi90 lentzi90 closed this May 11, 2024
@lentzi90 lentzi90 deleted the lentzi90/feature-gate-naming-release-1.7 branch May 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machineset Issues or PRs related to machinesets area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants