-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Feature gate for old infra machine naming #10511
🌱 Feature gate for old infra machine naming #10511
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
There is a breaking change to the way infra machines are named in v1.7.0. This commit adds a feature gate for getting the old behavior back. It defaults to disabled so the new behavior stays. It is also marked as deprecated so it can be removed in a future minor release. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
8aef20a
to
2b09d1d
Compare
Slack discussion: https://kubernetes.slack.com/archives/C8TSNPY4T/p1715075887741569 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
See #10587 |
What this PR does / why we need it:
There is a breaking change to the way infra machines are named in v1.7.0. This commit adds a feature gate for getting the old behavior back. It defaults to disabled so the new behavior stays. It is also marked as deprecated so it can be removed in a future minor release.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10463 (temporary fix to give more time to adapt)
/area provider/control-plane-kubeadm
/area machineset