-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update to golangci-lint v1.18.0 #1415
✨ Update to golangci-lint v1.18.0 #1415
Conversation
S1011: should replace loop with `x = append(x, y...)`
Updates .golangci.yml to enable all linters by default and disable noisy ones. This explicitly documents which linters are not being used by the project.
Hi @tpounds. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- scopelint | ||
- staticcheck | ||
- unparam | ||
- unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see if we can shorten this list. Ideally, I'd like to see if we can get down to just disabling dupl
, gochecknoglobals
, gochecknoinits
, gocyclo
, and lll
, otherwise this lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@detiber Agree. I tried enabling a few others but they are all pretty noisy right now. I figured this was a good starting point to at least document which linters are disabled and let someone take a stab at pruning this list over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
/lgtm |
/ok-to-test |
# Run with --fast=false for more extensive checks | ||
fast: true | ||
issue: | ||
max-same-issues: 0 | ||
max-per-linter: 0 | ||
max-issues-per-linter: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@detiber FYI I just added a commit to address this incorrect option.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tpounds, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Updates to the latest golangci-lint release that includes fixes for Go 1.13.x. Also, contains minor fixes for
gosimple
warnings and enables all linters by default, disabling any that are current noisy.