-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update to golangci-lint v1.18.0 #1415
Merged
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:master
from
tpounds:golangci-lint-v1.18.0
Sep 12, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,22 @@ | ||
linters: | ||
enable: | ||
- govet | ||
- golint | ||
- gofmt | ||
- goimports | ||
- structcheck | ||
- varcheck | ||
- interfacer | ||
- unconvert | ||
- ineffassign | ||
- goconst | ||
- gocyclo | ||
- misspell | ||
- nakedret | ||
- prealloc | ||
- gosec | ||
disable-all: true | ||
enable-all: true | ||
disable: | ||
- dupl | ||
- errcheck | ||
- funlen | ||
- gochecknoglobals | ||
- gochecknoinits | ||
- gocritic | ||
- lll | ||
- scopelint | ||
- staticcheck | ||
- unparam | ||
- unused | ||
# Run with --fast=false for more extensive checks | ||
fast: true | ||
issue: | ||
issues: | ||
max-same-issues: 0 | ||
max-per-linter: 0 | ||
max-issues-per-linter: 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @detiber FYI I just added a commit to address this incorrect option. |
||
run: | ||
deadline: 2m | ||
skip-files: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see if we can shorten this list. Ideally, I'd like to see if we can get down to just disabling
dupl
,gochecknoglobals
,gochecknoinits
,gocyclo
, andlll
, otherwise this lgtmThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@detiber Agree. I tried enabling a few others but they are all pretty noisy right now. I figured this was a good starting point to at least document which linters are disabled and let someone take a stab at pruning this list over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm