Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement scale up for KubeadmControlPlane #1968

Merged
merged 1 commit into from
Jan 3, 2020
Merged

✨ Implement scale up for KubeadmControlPlane #1968

merged 1 commit into from
Jan 3, 2020

Conversation

detiber
Copy link
Member

@detiber detiber commented Dec 27, 2019 •
edited

What this PR does / why we need it:

  • Adds support to scale up a KubeadmControlPlane

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to: #1756
Builds on: #1925, #1973

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2019
@detiber detiber changed the title ✨ Implement scale up for KubeadmControlPlane [WIP] ✨ Implement scale up for KubeadmControlPlane Dec 27, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2019
@detiber detiber force-pushed the kcpScaleUp branch 2 times, most recently from fc11bb9 to 1f83808 Compare December 30, 2019 18:54
@detiber detiber changed the title [WIP] ✨ Implement scale up for KubeadmControlPlane ✨ Implement scale up for KubeadmControlPlane Dec 30, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 30, 2019
@detiber
Copy link
Member Author

detiber commented Dec 30, 2019

This should be good to go now. I had to hack around the known webhook issue, but once I did that I was able to successfully test bringing up a KubeadmControlPlane and scaling it up to 3 replicas.

@detiber
Copy link
Member Author

detiber commented Dec 30, 2019

/assign @chuckha

@detiber
Copy link
Member Author

detiber commented Dec 31, 2019

/assign @chuckha
This should be ready for review now

@detiber
Copy link
Member Author

detiber commented Jan 2, 2020

/assign @ncdc

vincepri
vincepri reviewed Jan 2, 2020
View reviewed changes
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Outdated Show resolved Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go Show resolved Hide resolved
@detiber detiber force-pushed the kcpScaleUp branch 3 times, most recently from e2542a6 to cec82e6 Compare January 2, 2020 20:45
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2020
@detiber
Copy link
Member Author

detiber commented Jan 3, 2020

/hold
waiting for #1991 to merge and rebase

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2020
@detiber detiber force-pushed the kcpScaleUp branch 3 times, most recently from a6e0636 to a9e0fdd Compare January 3, 2020 19:19
@detiber
Copy link
Member Author

detiber commented Jan 3, 2020

Rebased to pick up the interface removal changes, also rebased on top of #1973

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 3, 2020
@detiber
Copy link
Member Author

detiber commented Jan 3, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2020
vincepri
vincepri approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 02cac5c into kubernetes-sigs:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc left review comments

@vincepri vincepri vincepri approved these changes

Assignees

@ncdc ncdc

@chuckha chuckha

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@detiber @k8s-ci-robot @ncdc @vincepri @chuckha