-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Start populating KubeadmControlPlane Status #1973
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0193d5c
to
792cb8f
Compare
/test pull-cluster-api-test |
/assign @chuckha |
/assign @ncdc |
👀 |
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
controlplane/kubeadm/controllers/kubeadm_control_plane_controller_test.go
Show resolved
Hide resolved
/hold |
Actually, there's another change I want to make |
ok, now it should be good to go |
controlplane/kubeadm/controllers/kubeadm_control_plane_controller.go
Outdated
Show resolved
Hide resolved
/lgtm |
What this PR does / why we need it:
Up until now we haven't populated the status field on KubeadmControlPlane, this PR attempts to start doing that by updating Status.Replicas, Status.ReadyReplicas, and Status.UnavailableReplicas
Related to: #1756