🏃[e2e] add ClusterProvider and ClusterProxy #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
fabriziopandini
force-pushed
the
e2e-add-clusterprovider-and-clusterproxy
branch
from
97a2317
to
6f8b272
Compare
|
/milestone v0.3.4 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
detiber
reviewed
Apr 15, 2020
sedefsavas
reviewed
Apr 15, 2020
fabriziopandini
force-pushed
the
e2e-add-clusterprovider-and-clusterproxy
branch
from
6f8b272
to
fc81772
Compare
sedefsavas
reviewed
Apr 15, 2020
sedefsavas
reviewed
Apr 15, 2020
sedefsavas
reviewed
Apr 15, 2020
fabriziopandini
force-pushed
the
e2e-add-clusterprovider-and-clusterproxy
branch
from
fc81772
to
20e2800
Compare
|
@sedefsavas thanks for the feedback! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces it is required to have a cleaner separation between:
This change is required in order to implement tests on self-hosted clusters (more details in the issue)
Which issue(s) this PR fixes:
Fixes #2910
xref #2753
xref #2637
xref #2636
/assign @vincepri
/assign @sedefsavas