Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃[e2e] Reorg helpers func #2922

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR is a big reshuffle of all the helpers defined in the E2E test framework so they are now consistently organized "by objects" (more detail in the issue)

No other changes were applied, except adding // Deprecated to few helpers that are not anymore in line with the recent changes in the test framework (eg. AssertAllClusterAPIResourcesAreGone ApplyYAMLURL are now deprecated).

All the deprecated helpers are now in a single deprecated.go file.

Which issue(s) this PR fixes:
Fixes #2921

xref #2753
xref #2637
xref #2636

/assign @vincepri
/assign @sedefsavas

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 16, 2020
@fabriziopandini
Copy link
Member Author

@benmoss thanks for the feedback! fixed!

@vincepri
Copy link
Member

/test pull-cluster-api-apidiff

@k8s-ci-robot
Copy link
Contributor

@vincepri: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-build
  • /test pull-cluster-api-make
  • /test pull-cluster-api-verify
  • /test pull-cluster-api-test
  • /test pull-cluster-api-integration
  • /test pull-cluster-api-capd-e2e

Use /test all to run all jobs.

In response to this:

/test pull-cluster-api-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri vincepri closed this Apr 16, 2020
@vincepri vincepri reopened this Apr 16, 2020
@vincepri
Copy link
Member

/test pull-cluster-api-apidiff

@fabriziopandini
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 16, 2020

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff 87009ce link /test pull-cluster-api-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

@fabriziopandini

sigs.k8s.io/cluster-api/test/framework
  Incompatible changes:
  - WatchControllerLogs: removed
  - WatchControllerLogsInput: removed

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Apr 16, 2020

@vincepri Those functions were added by #2911 yesterday;
I'm renaming them into WatchDeploymentLogs and WatchDeploymentLogsInput because this is what they are really doing (nothing controller specific)

@vince
Copy link

vince commented Apr 16, 2020

@fabriziopandini wrong Vince!

@sedefsavas
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@vincepri
Copy link
Member

/milestone v0.3.4

@k8s-ci-robot k8s-ci-robot added this to the v0.3.4 milestone Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8284f6b into kubernetes-sigs:master Apr 16, 2020
@fabriziopandini fabriziopandini deleted the e2e-reorg-helpers branch April 18, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E reorgs helpers
6 participants