-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃[e2e] Reorg helpers func #2922
🏃[e2e] Reorg helpers func #2922
Conversation
f972a2c
to
87009ce
Compare
@benmoss thanks for the feedback! fixed! |
/test pull-cluster-api-apidiff |
@vincepri: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-apidiff |
/retest |
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@fabriziopandini wrong Vince! |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/milestone v0.3.4 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR is a big reshuffle of all the helpers defined in the E2E test framework so they are now consistently organized "by objects" (more detail in the issue)
No other changes were applied, except adding
// Deprecated
to few helpers that are not anymore in line with the recent changes in the test framework (eg.AssertAllClusterAPIResourcesAreGone
ApplyYAMLURL
are now deprecated).All the deprecated helpers are now in a single
deprecated.go
file.Which issue(s) this PR fixes:
Fixes #2921
xref #2753
xref #2637
xref #2636
/assign @vincepri
/assign @sedefsavas