Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the node's UID to the machine's noderef. #348

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

spew
Copy link
Contributor

@spew spew commented Jun 14, 2018

What this PR does / why we need it:
This PR adds the node's UID to the machine's noderef field. This will allow the machine controller to definitively know what node belongs to a machine.

To test I ran a custom machine-controller, after doing so, the ouput of kubectl get machines:

$ kubectl get machines -o json | jq '.items[].status'
{
  "lastUpdated": "2018-06-14T23:02:09Z",
  "nodeRef": {
    "kind": "Node",
    "name": "gce-master-qqn5q",
    "uid": "18afd236-7023-11e8-b23f-42010a8a0002"
  },
  "providerStatus": null
}
{
  "lastUpdated": "2018-06-14T23:03:45Z",
  "nodeRef": {
    "kind": "Node",
    "name": "gce-node-47lts",
    "uid": "51546457-7026-11e8-b23f-42010a8a0002"
  },
  "providerStatus": null
}

Release note:

Now populate the associated node's UID in the machine.status.nodeRef field. 

@kubernetes/kube-deploy-reviewers

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2018
@spew
Copy link
Contributor Author

spew commented Jun 14, 2018

/assign @roberthbailey @k4leung4 @mkjelland

@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit a589fd0 into kubernetes-sigs:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants